Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: EventLoop::Polling::FiberEvent [fixup #14996] #15301

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix: EventLoop::Polling::FiberEvent [fixup #14996] #15301

merged 1 commit into from
Jan 7, 2025

Conversation

ysbaddaden
Copy link
Contributor

Reduces discrepancies with the refactored IOCP::FiberEvent and fixes a couple issues:

  1. No need to tie the event to a specific event loop;
  2. Clear wake_at after dequeueing the timer (MT bug).

@ysbaddaden
Fix: EventLoop::Polling::FiberEvent
73ff1f2 
Reduces discrepancies with the IOCP::FiberEvent and fixes a couple
issues:

1. No need to tie the event to a specific event loop;
2. Clear wake_at _after_ dequeueing the timer (MT bug).
@ysbaddaden ysbaddaden self-assigned this Dec 20, 2024
@straight-shoota straight-shoota added this to the 1.15.0 milestone Jan 6, 2025
@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. and removed kind:refactor labels Jan 6, 2025
@straight-shoota straight-shoota merged commit 8cf8262 into crystal-lang:master Jan 7, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees

@ysbaddaden ysbaddaden

Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:runtime
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ysbaddaden @straight-shoota